Add deploy workflow for standalone CORS proxy #2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM @brandonpayton, what is the next step here? |
This reverts commit 58eadb6.
Thank you for looking, @adamziel. I did a bit more to tighten this up for merging. Now let's go ahead and merge so we can manually trigger a run and test it. |
brandonpayton
added a commit
that referenced
this pull request
Dec 4, 2024
## Motivation for the change, related issues We want to move the CORS proxy to a separate host from playground.wordpress.net. In order to continue using the proxy from playground.wordpress.net, the CORS proxy needs to support cross-origin requests to itself. ## Implementation details This PR updates the CORS proxy to again respond with CORS-related headers for supported origins. Currently, supported origins are "https://playground.wordpress.net" and local origins based on "127.0.0.1" and "localhost". ## Testing Instructions (or ideally a Blueprint) - Once #2022 is merged, deploy this branch to the dedicated CORS proxy host. - Create a Blueprint that uses the dedicated CORS proxy host. - Confirm the Blueprint works with playground.wordpress.net. - Confirm the Blueprint works with the local dev server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
It is likely that some folks will attempt to abuse the CORS proxy, and if they succeed despite our defensive measures, we would like to limit the risk of that abuse being associated with the Playground web app itself. Let's separate the CORS proxy from the web app.
Implementation details
This PR adds a workflow to deploy the CORS proxy to a dedicated host.
We need to help folks transition from the CORS proxy on playground.wordpress.net to the proxy on the dedicated host. We could even consider keeping a more restricted version of the proxy on playground.wordpress.net, though having two instances would likely be confusing.
Testing Instructions (or ideally a Blueprint)