Preserve chroot across all worker-managed PHP instances #2704
+82
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
deleted the
preserve-chroot-across-all-managed-php-instances
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
After this PR,
phpWorker.chdir("/tmp")remains in effect for all subsequently spawned PHP instances. Before this PR, it spawns a single PHP instance, sets the chdir there, and immediately reaps it, leaving the chdir unused by all future PHP instances.Implementation details
Ensures
PHPWorkercallsphp.chdir()on all newly spawned PHP instances. The underlying logic may also make sense at thePHPProcessManagerlevel. However, since I needplaygroundClient.chdir()to work correctly, we'll need a little something at the worker level as well – therefore I feel confident merging this change and revisiting it later if needed.Testing Instructions (or ideally a Blueprint)
CI, this PR comes with a test.