Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell commands #114

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Shell commands #114

merged 1 commit into from
Aug 26, 2022

Conversation

dingo-d
Copy link
Member

@dingo-d dingo-d commented Aug 20, 2022

This PR depends on #113. Once that is merged, this PR should be rebased to the master branch.

The PR adds rules about disallowing the usage of the backtick operator and is the continuation of the additions of 'modern' PHP code in the WordPress PHP Coding Standards handbook based on the make post by Juliette Reinders Folmer.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dingo-d go-d Would be nice if you could rebase this commit on master without the other commits as this commit shouldn't conflict anyway and IMO is ready for merge.

@dingo-d dingo-d marked this pull request as ready for review August 26, 2022 08:24
@jrfnl jrfnl merged commit 1d40ea1 into master Aug 26, 2022
@jrfnl jrfnl deleted the shell-commands branch August 26, 2022 11:54
@jrfnl
Copy link
Member

jrfnl commented Aug 26, 2022

Merging this now as @GaryJones is AFK for the next few weeks. If needs be, additional textual tweaks can still be made in a follow up commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants