Skip to content

Conversation

desrosj
Copy link
Member

@desrosj desrosj commented Sep 11, 2025

This aims to add proper AVIF support to GD for PHP 8.1+ containers.

@desrosj desrosj self-assigned this Sep 11, 2025
@desrosj desrosj marked this pull request as ready for review September 12, 2025 16:14
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
Copy link
Member Author

desrosj commented Sep 12, 2025

This should not be merged until #185 is merged into trunk and the HEAD branch for this pull request to avoid making changes to legacy containers unnecessarily.

@desrosj desrosj requested a review from johnbillion September 13, 2025 10:40
@desrosj
Copy link
Member Author

desrosj commented Sep 16, 2025

I'm getting an error when running the media test group locally to test these containers:

1) Test_Image_Resize_GD::test_resize_avif
imageavif(): avif error - Could not encode image: No codec available

Switching to draft until, I can work through this.

@desrosj desrosj marked this pull request as draft September 16, 2025 02:21
AVIF is not supported in GD for these versions. Add this at a later date if necessary for something else (like HEIC/HEIF support).
@desrosj desrosj marked this pull request as ready for review September 17, 2025 02:38
@desrosj
Copy link
Member Author

desrosj commented Sep 17, 2025

I think this is ready to go. WordPress/wordpress-develop#9919 shows the tests that were previously skipped for GD as running and passing.

@desrosj
Copy link
Member Author

desrosj commented Sep 26, 2025

I just gave another look, and I think this is ready to go. Going to merge and confirm in WordPress/wordpress-develop#trunk.

@desrosj desrosj merged commit 66a5f88 into trunk Sep 26, 2025
23 checks passed
@desrosj desrosj deleted the fix/avif-support branch September 26, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant