Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Side Panel with Navigation Example #2106

Merged
merged 14 commits into from
May 19, 2023

Conversation

myvuuu
Copy link
Collaborator

@myvuuu myvuuu commented Mar 22, 2023

Summary

Fixes: #1910

Release Category

Examples


Checklist

  • MDX documentation adheres to Canvas Kit's standard MDX template
  • Label ready for review has been added to PR

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

giphy

@codesandbox
Copy link

codesandbox bot commented Mar 22, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@myvuuu myvuuu added the blocker This ticket blocks work for another team label Mar 22, 2023
@cypress
Copy link

cypress bot commented Mar 22, 2023

1 flaky tests on run #5759 ↗︎

0 882 2 0 Flakiness 1

Details:

Merge 5691c26 into 9e43c41...
Project: canvas-kit Commit: f134cb7dc1 ℹ️
Status: Passed Duration: 07:32 💡
Started: May 19, 2023 2:50 PM Ended: May 19, 2023 2:57 PM
Flakiness  cypress/integration/Autocomplete.spec.ts • 1 flaky test

View Output Video

Test Artifacts
... > when a value is entered > when down arrow key is pressed > when the user presses the enter key > when the use hits the "2" key > should change the filtered results Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mannycarrera4 mannycarrera4 removed the blocker This ticket blocks work for another team label Mar 23, 2023
@mannycarrera4
Copy link
Contributor

We'll have to update some padding to make sure these items are aligned
Screen Shot 2023-03-27 at 9 12 46 AM
Should be a simple fix!

@alanbsmith alanbsmith added the ready for review Code is ready for review label Mar 28, 2023
@github-actions github-actions bot requested a review from jamesfan March 28, 2023 17:46
@jaclynjessup jaclynjessup removed the ready for review Code is ready for review label Apr 3, 2023
@RayRedGoose RayRedGoose added the on hold PR is on hold until further notice label Apr 7, 2023
@alanbsmith alanbsmith removed the on hold PR is on hold until further notice label May 11, 2023
@myvuuu myvuuu added the ready for review Code is ready for review label May 15, 2023
Copy link
Collaborator

@williamjstanton williamjstanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great!! I left one comment of feedback on the aria-label string for you. The list markup looks like it is working really well!

Copy link
Collaborator

@williamjstanton williamjstanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies in advance... I should have spotted this in my last review. I just noticed the second expandable did not have the list markup like the first expandable did.

</Expandable.Title>
<Expandable.Icon iconPosition="end" flex="1" />
</StyledExpandable>
<Expandable.Content paddingY="zero" paddingX="zero">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for missing this earlier in the morning! This line is missing as="ul" prop.

<Expandable.Content paddingY="zero" paddingX="zero">
{cakes.map(item => {
return (
<StyledLink
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, these StyledLink components are not set inside of <li> elements.

</Expandable.Title>
<Expandable.Icon iconPosition="end" flex="1" />
</StyledExpandable>
<Expandable.Content paddingY="zero" paddingX="zero">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Expandable.Content paddingY="zero" paddingX="zero">
<Expandable.Content paddingY="zero" paddingX="zero" as="ul">

@mannycarrera4 mannycarrera4 added automerge and removed ready for review Code is ready for review labels May 19, 2023
@alanbsmith alanbsmith merged commit bd1e86b into Workday:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SidePanel with navigation example
7 participants