fix(button): Fix Component Selector Issue #474
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to some changes in the way we use
@emotion/styled
, we are no longer able use component selectors in Emotion via Babel. This is becausestyled
functions using Emotion'sCreateStyled
, like our own Canvas styled component, does not work with the babel plugin for emotion.This is a known issue and will be fixed in Emotion 11 by emotion-js/emotion#1220 via a mapping configuration so the plugin knows about custom styled functions.
For now the fix is to just remove the usage of component selectors. This PR addresses that by using an identifier class name (similar to how Emotion identifies component selectors) in
IconButton
and then styling that class name inIconButtonToggleGroup
.Checklist
yarn test
passespackage.json
canvas-kit-react
and/orcanvas-kit-css
universal modules, ifapplicable
Additional References