Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): Fix Component Selector Issue #474

Merged
merged 5 commits into from
Feb 19, 2020
Merged

fix(button): Fix Component Selector Issue #474

merged 5 commits into from
Feb 19, 2020

Commits on Feb 19, 2020

  1. fix(button): Add identifier class to IconButton

    @lychyi
    lychyi committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    f1d6c48 View commit details
    Browse the repository at this point in the history

  2. fix(button): Remove component selector

    @lychyi
    lychyi committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    c12f500 View commit details
    Browse the repository at this point in the history

  3. test(button): Use getByRole query instead

    @lychyi
    lychyi committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    17e5ab9 View commit details
    Browse the repository at this point in the history

  4. Update modules/button/react/spec/IconButton.spec.tsx 

    Co-Authored-By: Alex Nicholls <anicholls3@gmail.com>
    @lychyi @anicholls
    lychyi and anicholls authored Feb 19, 2020
    Configuration menu
    Copy the full SHA
    48acd11 View commit details
    Browse the repository at this point in the history

  5. chore: Fix linting issue from Github suggestion

    @lychyi
    lychyi committed Feb 19, 2020
    Configuration menu
    Copy the full SHA
    1541d92 View commit details
    Browse the repository at this point in the history