feat: Add fetch_completions method to Run class #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to fetch completions for a run via the /v1/_/agents/{agent_id}/runs/{run_id}/completions endpoint.
Changes:\n- Added CompletionUsage, Message, Completion, and CompletionsResponse models\n- Added fetch_completions() method to Run class\n- Added comprehensive test suite with success and error cases\n- Added detailed test documentation explaining test rationale\n\nThe fetch_completions method allows retrieving the full conversation history and token usage information for a completed run.
Fixed type error in Run._agent assignment by making the api field a property in the _AgentBase protocol to match the Agent class implementation. This ensures proper type compatibility between Agent and _AgentBase.
guillaq
reviewed
Feb 21, 2025
guillaq
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to fetch completions for a run via the /v1/_/agents/{agent_id}/runs/{run_id}/completions endpoint.
Changes:\n- Added CompletionUsage, Message, Completion, and CompletionsResponse models\n- Added fetch_completions() method to Run class\n- Added comprehensive test suite with success and error cases\n- Added detailed test documentation explaining test rationale\n\nThe fetch_completions method allows retrieving the full conversation history and token usage information for a completed run.