Skip to content

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Aug 2, 2018

Changes

Added suggestors for PropsMeta changes:

  @Props()
  class FooProps extends UiProps {
+   static const PropsMeta meta = $metaForFooProps;
+
    String foo;
  }

* Also handles empty props classes.

- const $Props(FooProps),
+ FooProps.meta,

* Also handles multiline $Props() usages.

- const $PropKeys(FooProps)
+ FooProps.meta.keys

* Also handles multiline $PropKeys() usages.

Code Review

@Workiva/app-frameworks
@georgelesica-wf

@evanweible-wf evanweible-wf changed the title Add suggestors for PropsMeta changes AF-1928 Add suggestors for PropsMeta changes Aug 2, 2018
@rmconsole-wf
Copy link

rmconsole-wf commented Aug 2, 2018

Merge Requirements Unmet ❌

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

  • Dependency Scan Clean (smithy build not yet successful)
  • Required artifacts are reported in build. See documentation for more details on build artifact requirements.
    • python requires one of: pip.lock, python3_pip_deps.txt, python2_pip_deps.txt

General Information

Ticket(s):

Code Review(s): #2

Reviewers: corwinsheahan-wf, sebastianmalysa-wf

Additional Information

Watchlist Notifications: None

	This PR will not Auto-Merge because a project is excluded from the 
	Automerge Projects on this repo.
	Project: AF
	If you are the maintainer of this repo and would like to allow this project to automerge,
	 please update the automerge projects list on the [Rosie Control panel](https://w-rmconsole.appspot.com/rosie/Workiva/over_react_codemod/).

Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Friday, August 31 12:48 PM CST

@aviary-wf
Copy link

aviary-wf commented Aug 2, 2018

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.


def props_metas_suggest(lines, path):
for line_number, line in enumerate(lines):
if line.startswith('@Props('):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look for @PropsMixin() as well

@corwinsheahan-wf
Copy link
Contributor

corwinsheahan-wf commented Aug 31, 2018

+10

  • Suggestors for props meta work as expected by PR message

@corwinsheahan-wf
Copy link
Contributor

QA +1

  • CI will not pass yet since there is not Dockerfile.

@colefeisthamel-wf
Copy link

RM +1 most recent PR #28 has a clean deps scan which is the version being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants