-
Notifications
You must be signed in to change notification settings - Fork 7
AF-1928 Add suggestors for PropsMeta changes #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Merge Requirements Unmet ❌Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.
General InformationTicket(s): Code Review(s): #2 Reviewers: corwinsheahan-wf, sebastianmalysa-wf Additional InformationWatchlist Notifications: None
Note: This is a shortened report. Click here to view Rosie's full evaluation. |
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
|
||
def props_metas_suggest(lines, path): | ||
for line_number, line in enumerate(lines): | ||
if line.startswith('@Props('): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look for @PropsMixin()
as well
+10
|
QA +1
|
RM +1 most recent PR #28 has a clean deps scan which is the version being used |
Changes
Added suggestors for PropsMeta changes:
* Also handles empty props classes.
* Also handles multiline
$Props()
usages.* Also handles multiline
$PropKeys()
usages.Code Review
@Workiva/app-frameworks
@georgelesica-wf