FW-56 Add skynet.yaml #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
run_tests.sh
Outdated
Comment on lines
8
to
10
| pub get | ||
|
|
||
| pub run test --file-reporter=json:$filename.json || RESULT=1 |
There was a problem hiding this comment.
Would you mind changing these to use the new CLI? The top-level pub CLI is now deprecated in favor of dart pub, and pub run test specifically is replaced by dart test:
Suggested change
| pub get | |
| pub run test --file-reporter=json:$filename.json || RESULT=1 | |
| dart pub get | |
| dart test --file-reporter=json:$filename.json || RESULT=1 |
There was a problem hiding this comment.
My bad of course, updated.
evanweible-wf
approved these changes
May 24, 2022
|
QA +1
|
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs the unit tests inside skynet to satisfy the release pipeline QA requirement.