-
Notifications
You must be signed in to change notification settings - Fork 30
MOBILE-2278: Add support for iOS WKWebView #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
travissanderson-wf
merged 6 commits into
Workiva:master
from
brianblanchard-wf:MOBILE-2278
Nov 7, 2016
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d0ad7dc
MOBILE-2278: Adding stricter check for safari
brianblanchard-wf ee1a90e
MOBILE-2278: Adding support for WKWebView
brianblanchard-wf ef0d3ba
MOBILE-2278: Formatting browser.dart
brianblanchard-wf 6ea9381
MOBILE-2278: Adding vendor null checks
brianblanchard-wf cbd5906
MOBILE-2278: Adding back dart format
brianblanchard-wf 5220a0f
MOBILE-2278: Formatting code
brianblanchard-wf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,4 +26,4 @@ artifacts: | |
documentation: | ||
- ./doc/api/api.tar.gz | ||
pub: | ||
- ./platform_detect.pub.tgz | ||
- ./platform_detect.pub.tgz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clairesarsam-wf @robbecker-wf what do you guys think about detecting these "sub" type browsers like WkWebView is for the most part the same as Safari, similar to Rob's question about separating the detection of IE vs Edge from earlier. When WKWebView is detected, should isSafari return true as well as isWKWebView?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronlademann-wf too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@travissanderson-wf We could do that but the issue is if we return true for
isSafari
in theWKWebView
the there would not be a version because theSafari
and theWKWebView
have different version strings.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it could still have a version, currently it would be different depending on if it was parsed out by _Safari or _WKWebView, I just mean we could change the getter for
isSafari = this == _safari || this == _wkWebView
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I could see it being useful to know if you're running in a webview.