CPLAT-8042 Implement/Expose useLayoutEffect Hook #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joebingham-wk
approved these changes
Jan 22, 2020
| @@ -183,6 +184,47 @@ UseRefTestComponent(Map props) { | |||
| ]); | |||
| } | |||
|
|
|||
| final random = new Random(); | |||
There was a problem hiding this comment.
#nit no more new keyword!
Suggested change
| final random = new Random(); | |
| final random = Random(); |
greglittlefield-wf
approved these changes
Jan 23, 2020
| return React.useEffect(wrappedSideEffect, dependencies); | ||
| } else { | ||
| return React.useEffect(wrappedSideEffect); | ||
| } |
There was a problem hiding this comment.
I assume these changes mean passing in null for dependencies is the same as not passing it?
# Conflicts: # example/test/function_component_test.dart # lib/hooks.dart # lib/react_client/react_interop.dart # test/hooks_test.dart
greglittlefield-wf
approved these changes
Jan 23, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support useLayoutEffect hook in
react-dart.Changes
useLayoutEffectfunction.Please review: @greglittlefield-wf @aaronlademann-wf @joebingham-wk