Default index-relationships to true

.github/workflows/tests.yaml

@@ -37,9 +37,6 @@ jobs:
           dart run scip_dart ./snapshots/input/basic-project
           ./scip snapshot --to ./snapshots/output/basic-project
 
-          dart run scip_dart --index-relationships ./snapshots/input/relationships-project
-          ./scip snapshot --to ./snapshots/output/relationships-project
-
           if [[ -z "$(git status --porcelain ./snapshots/output)" ]];
           then
             echo "No changes to snapshot files"

Makefile

@@ -7,15 +7,10 @@ gen-snap_basic-project:
 	dart run scip_dart ./snapshots/input/basic-project
 	scip snapshot --to ./snapshots/output/basic-project
 
-gen-snap_relationships-project:
-	dart run scip_dart --index-relationships ./snapshots/input/relationships-project
-	scip snapshot --to ./snapshots/output/relationships-project
-
 gen-snap_diagnostics:
 	dart run scip_dart ./snapshots/input/diagnostics
 	scip print --json ./index.scip | jq '.documents[].occurrences[] | select(.diagnostics)' | jq -s . > ./snapshots/output/diagnostics/output.json
 
-
 run:
 	dart run scip_dart ./snapshots/input/staging-project --verbose
 

bin/scip_dart.dart

@@ -10,13 +10,6 @@ import 'package:scip_dart/src/version.dart';
 
 Future<void> main(List<String> args) async {
   final result = (ArgParser()
-        ..addFlag(
-          'index-relationships',
-          defaultsTo: false,
-          help: 'Whether or not to index symbol relationships. '
-              'This functionality is currently in alpha, and should not be '
-              'considered stable and accurate.',
-        )
         ..addFlag(
           'performance',
           aliases: ['perf'],
@@ -34,6 +27,10 @@ Future<void> main(List<String> args) async {
           defaultsTo: false,
           help: 'Display the current version of scip-dart',
         )
+        ..addFlag(
+          'index-relationships',
+          help: 'DEPRECATED, has no effect on executed code',
+        )
         ..addMultiOption(
           'path',
           abbr: 'p',

lib/src/flags.dart

@@ -7,13 +7,9 @@ class Flags {
   bool get performance => _performance;
   bool _performance = false;
 
-  bool get indexRelationships => _indexRelationships;
-  bool _indexRelationships = false;
-
   void init(ArgResults results) {
     _verbose = results['verbose'] as bool? ?? false;
     _performance = results['performance'] as bool? ?? false;
-    _indexRelationships = results['index-relationships'] as bool? ?? false;
   }
 
   static Flags get instance => _instance;

lib/src/scip_visitor.dart

@@ -5,7 +5,6 @@ import 'package:analyzer/error/error.dart';
 import 'package:analyzer/source/line_info.dart';
 import 'package:package_config/package_config.dart';
 import 'package:pubspec_parse/pubspec_parse.dart';
-import 'package:scip_dart/src/flags.dart';
 import 'package:scip_dart/src/metadata.dart';
 import 'package:scip_dart/src/gen/scip.pb.dart';
 import 'package:scip_dart/src/relationship_generator.dart';
@@ -67,10 +66,7 @@ class ScipVisitor extends GeneralizingAstVisitor {
 
     final element = node.declaredElement!;
 
-    List<Relationship>? relationships;
-    if (Flags.instance.indexRelationships) {
-      relationships = relationshipsFor(node, element, _symbolGenerator);
-    }
+    final relationships = relationshipsFor(node, element, _symbolGenerator);
 
     _registerAsDefinition(
       element,