Skip to content

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Jan 28, 2024

FEA-3240

I recently discovered that analyzer v5.13.0 can successfully analyze dart 3 code, which in relation means that scip-dart can run on dart3 code

This pr updates the upper bound of the scip-dart cli to allow indexing using any dart version above 2.19.6, and below dart v4

This pr also adds a special snapshot project just for these dart3 features. Reviewing the results of that snapshot file should verify dart 3 features ran on an analyzer v5.13

The previous "dart 3 support branch" has now become the analyzer v6 branch: #68, since this bumps the required lower bound up to dart 3, it will need to stay in draft state

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk changed the title initial support for dart3 Support dart 3 Jan 28, 2024
@matthewnitschke-wk matthewnitschke-wk changed the title Support dart 3 Support Dart v3 Jan 28, 2024
@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review January 28, 2024 23:59
@bender-wk bender-wk changed the title Support Dart v3 FEA-3240: Support Dart v3 Jan 28, 2024
@isaacharrisholt
Copy link
Contributor

Is there anything I can do to help get this in? Dart 3 has been out for a while now, and a fair few projects have started moving over.

@matthewnitschke-wk
Copy link
Contributor Author

Is there anything I can do to help get this in? Dart 3 has been out for a while now, and a fair few projects have started moving over.

Sorry @isaacharrisholt, I must have missed your message! We've been in the progress of migrating a massive dart 2 project and this update just hasn't been a priority for us at the moment

If you want to take what I've got here, and polish it up, I'd be happy to give that a review. Otherwise it might be a few more months before we can commit to getting this merged

@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review May 27, 2025 07:41
@matthewnitschke-wk
Copy link
Contributor Author

QA +1

  • tested locally, but also unit test validate that scip-dart is executable in both dart 2 and 3

@matthewnitschke-wk
Copy link
Contributor Author

🚀 @Workiva/release-management-p 🚢

@micahbeeman-wf
Copy link

RM +1

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@btr-rmconsole-7 btr-rmconsole-7 bot merged commit e627198 into master May 28, 2025
27 checks passed
@btr-rmconsole-7 btr-rmconsole-7 bot deleted the dart3 branch May 28, 2025 14:59
@matthewnitschke-wk
Copy link
Contributor Author

@isaacharrisholt Heads up! This functionality will be available once #177 merges, under the eventual v1.6.2

Thanks for your patience on this! lmk if you have any issues

@isaacharrisholt
Copy link
Contributor

@isaacharrisholt Heads up! This functionality will be available once #177 merges, under the eventual v1.6.2

Thanks for your patience on this! lmk if you have any issues

That's amazing, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants