FEDX-1213: Localized element selection logic to the SymbolGenerator #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
matthewnitschke-wk
changed the title
| offset: node.name.offset, | ||
| length: node.name.length, | ||
| ); | ||
| return; |
There was a problem hiding this comment.
This fixes #120
Comment on lines
+47
to
+49
| print(AnimalType.values); | ||
| // ^^^^^ reference scip-dart pub dart:core 2.19.0 dart:core/`print.dart`/print(). | ||
| // ^^^^^^^^^^ reference scip-dart pub dart_test 1.0.0 lib/`more.dart`/AnimalType# |
There was a problem hiding this comment.
This validates the case in #37, don't index .values
| // ^^^^ reference local 0 | ||
| required this.value, | ||
| // ^^^^^ reference scip-dart pub dart_test 1.0.0 lib/`other.dart`/Foo#value. | ||
| // ^^^^^ definition scip-dart pub dart_test 1.0.0 lib/`other.dart`/Foo#`<constructor>`().(value) |
There was a problem hiding this comment.
named parameters are indexed as both references and definitions, this is due to the case mentioned in #120, where they are goto'd from a declaration side of things
Comment on lines
+71
to
+76
| // The values field on enums is synthetic, and has no explicit definition like | ||
| // other fields do. Skip indexing for this case. | ||
| if (element.enclosingElement is EnumElement && | ||
| element.name == 'values') { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
This is the part that closes #37
matthewnitschke-wk
changed the title
dustinlessard-wf
approved these changes
Jul 9, 2024
|
QA +1
🚀 @Workiva/release-management-p 🚢 |
rmconsole5-wk
deleted the
localized_element_selection_logic_to_symbol_generator
branch
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 parts to getting a symbol representation of a dart reference/definition: selecting the correct
Elementbased on a providedAstNode, and building the string using that selected elementBefore this PR, the element selection part was done directly within the scip_visitor, which is not exported from scip-dart. This PR moves all of this logic to the symbol_generator, which is exported and available
The SymbolGenerator was selected as the
elementFormethod is a necessary step in symbol generation. It seemed like a fitting, and convenient place (due to the pre-existing exporting of the class)Also, unrelated, but closes #37 and closes #120