FEA-1506: Fixed indexing on field parameters and import prefixes #16
Conversation
Merge Requirements Met ✅Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment. General InformationTicket(s): Code Review(s): #16
Reviewers: corwinsheahan-wf, matthewnitschke-wk Additional InformationWatchlist Notifications: None Note: This is a shortened report. Click here to view Rosie's full evaluation. |
matthewnitschke-wk
changed the title
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| // ^^^ definition scip-dart pub dart_test 1.0.0 lib/other.dart/Foo#<constructor>(). | ||
| // documentation ```dart | ||
| // ^^^ reference scip-dart pub dart_test 1.0.0 lib/other.dart/Foo# | ||
| // ^^^^ reference local 0 |
There was a problem hiding this comment.
named field parameters are now indexed, this is a local reference because its private
| // ^^^^ reference scip-dart pub dart_test 1.0.0 lib/more.dart/Animal#name. | ||
| // ^^^^ reference scip-dart pub dart_test 1.0.0 lib/more.dart/Animal#type. |
There was a problem hiding this comment.
Main fix in this pr, instead of skipping field parameters, they are indexed
These are not private, so they are not considered to be local
| import 'dart:math' as math; | ||
| // definition scip-dart pub dart_test 1.0.0 lib/more.dart/ | ||
| // ^^^^ definition scip-dart pub dart_test 1.0.0 lib/more.dart/math. | ||
| // documentation ```dart |
There was a problem hiding this comment.
as math was added to demonstrate the as indexing fix
Before, math was considered a reference, but it is actually a definition
| } else if (node is NormalFormalParameter) { | ||
| _visitNormalFormalParameter(node); |
There was a problem hiding this comment.
NormalFormalParameter both field and regular parameters
bender-wk
changed the title
|
|
||
| @override | ||
| void visitNode(AstNode node) { | ||
| // print(':: $node ${node.runtimeType}'); |
|
QA +1 Tests pass |
|
🚀 @Workiva/release-management-p 🚢 |
FEA-1506
Closes #14
Closes #15
Also reworked
scip-visitora bit, to abstract the process of creating a "definition" and a "reference" better