FEDX-2979: Pubspec Indexing followups #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bender-wk
changed the title
matthewnitschke-wk
changed the title
alanknight-wk
approved these changes
Apr 17, 2025
|
QA +1
🚀 @Workiva/release-management-p 🚢 |
btr-rmconsole-1
bot
deleted the
gracefully_handle_missing_pubspec_version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEDX-2979
versionis optional within a pubspec file, when its missing scip-dart will hard-fail on a NPE. We should cover this edge case since it is indeed optional. For the cases where the version is missing, use the scip wildcard fieldpublish_to: nonein a pubspec.yaml file implies that the pubspec should not be published. In an effort to not encounter many duplicates caused from this, we should considerpublish_to: nonean indication that no other pubspecs will be referencing this one, so we can omit the file symbol