Parity with IDE parameter indexing #22
Conversation
Merge Requirements Met ✅Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment. General InformationTicket(s): None found in title
Reviewers: evanweible-wf, matthewnitschke-wk Additional InformationWatchlist Notifications: None Note: This is a shortened report. Click here to view Rosie's full evaluation. |
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| // ^^^^^^ reference scip-dart pub dart_test 1.0.0 lib/more.dart/Animal# | ||
| // ^^^^ reference scip-dart pub dart_test 1.0.0 lib/more.dart/Animal#name. | ||
| // ^^^^ reference scip-dart pub dart_test 1.0.0 lib/more.dart/Animal#type. | ||
| // ^^^^ reference scip-dart pub dart_test 1.0.0 lib/more.dart/Animal#name. |
There was a problem hiding this comment.
This is targeting the this keyword, referencing the field, not the parameter definition
| // ^^^^ reference scip-dart pub dart_test 1.0.0 lib/more.dart/Animal#name. | ||
| // ^^^^ reference scip-dart pub dart_test 1.0.0 lib/more.dart/Animal#type. | ||
| // ^^^^ reference scip-dart pub dart_test 1.0.0 lib/more.dart/Animal#name. | ||
| // ^^^^ definition local 0 |
There was a problem hiding this comment.
This is targeting the parameter itself, hence its local definition (not accessible outside of the file)
matthewnitschke-wk
changed the title
| _registerAsDefinition(element); | ||
| } | ||
|
|
||
| _registerAsDefinition(element); |
There was a problem hiding this comment.
All parameters are definitions now, this is for parity with IDE navigation/analysis
matthewnitschke-wk
changed the title
|
QA +1 🚀 @Workiva/release-management-p 🚢 |
Closes #21
Within an editor, running goto definition on a parameter reference always navigates to the parameter definition, regardless on if its a field parameter (
this.foo) or a traditional parameter (String foo). Running goto definition on thethiswithin the field parameter, navigates to the field itself.In an effort to have parity with IDE navigation, this pr handles a reference on the
thiskeyword for field parameters. The pr also addresses the issue stated within #21, resolving inconsistencies in paramsThrough some local analysis, this pr reduces the scip lint count in wdesk_sdk from
3436to457