FEA-1741: Correctly index fields

[matthewnitschke-wk]

FEA-1741

There has been a longstanding issue with scip-dart where fields are not correctly indexed due to the synthetic get/set elements which are backing every field

This pr takes into account this edge case, pulling from the examples in deprecatalog and lsif_indexer

[rmconsole-wf]

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s):

• FEA-1741 | remove

Code Review(s): #32
Release Image Tags:

• drydock.workiva.net/workiva/scip-dart:4462922
• drydock.workiva.net/workiva/scip-dart:pr-32

Reviewers: matthewnitschke-wk, kimlarson-wk

Additional Information

Watchlist Notifications: None

	When this pull is merged I will add it to the following release:
	Version: scip-dart 1.0.6
	Release Ticket(s): RM-187414

---

Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Monday, April 17 02:04 PM CST

[aviary2-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[kimlarson-wk]

#nit should we go ahead and make this an else if to avoid the unnecessary second check?

[matthewnitschke-wk]

In this case, its necessary to hit both

the CompoundAssignmentExpression is to get the correct ast node, it can assign the element to be PropertyAccessorElement

And if element is PropertyAccessorElement in any case, we want its variable, not it's element node

Its a bit strange, but we're bound to the criteria of the ast/static analysis by a lot of this stuff

[matthewnitschke-wk]

QA +1

Verified generated scip files are correct, and no regressions exist in snapshots

[kimlarson-wk]

@Workiva/release-management-pp ready for merge.

[rmconsole-wf]

+1 from RM