FEA-2017: Relationships #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Comment on lines
+21
to
+25
| .where((type) => !type.isDartCoreObject) | ||
| .map((type) => Relationship( | ||
| symbol: symbolGenerator.symbolFor(type.element), | ||
| isImplementation: true, | ||
| )) |
There was a problem hiding this comment.
If a class has any supertypes, all of those supertypes (allSupertypes refers to every super type, including super types of super types) are relationships
matthewnitschke-wk
changed the title
| - uses: dart-lang/setup-dart@v1 | ||
| with: | ||
| sdk: stable | ||
| sdk: 2.18.7 |
There was a problem hiding this comment.
Currently only dart 2 is supported
Will have to spend some time considering what using scip generation on multiple different versions will look like
corwinsheahan-wf
approved these changes
Jul 11, 2023
|
QA +1 Verified generated snapshots are as expected |
|
🚀 @Workiva/release-management-p 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEA-2017
Adds support for "relationships" which will enable usage of "Go to Implementations" on classes and methods
Worth noting that the functionality that relationships provides is not available in the current release of sourcegraph (for dartlang). https://github.com/sourcegraph/sourcegraph/pull/52670, enables this functionality, and should be within sourcegraph's
v5.1version