Skip to content

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented May 29, 2023

FEA-1986

Issue Status

Currently only ./lib files are indexed

This was done intentionally to allow consumers to opt-in to indexing bin and test directories depending on their needs, with the potential downside of reduced preformance.

This PR abandons that desire, the majority of the tested code has already been indexed by the base file indexing, so the additional performance hits are just to index the files within test and bin respectively (which in practice is not that much worse)

This approach aligns a bit closer to scip-typescript where all files that are included in tsconfig.json are indexed. A later iteration can always support the ability to ignore a directory, if that is needed

Closes #42

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk changed the title index all files by default Deprecate -p/--path May 29, 2023
@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review May 29, 2023 17:51
@bender-wk bender-wk changed the title Deprecate -p/--path FEA-1986: Deprecate -p/--path Jun 1, 2023
@matthewnitschke-wk
Copy link
Contributor Author

QA +1

  • Changes included modifications to test directory as expected, all CI continues to pass

@matthewnitschke-wk
Copy link
Contributor Author

🚀 @Workiva/release-management-p 🚢

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index all dart files by default
6 participants