-
Notifications
You must be signed in to change notification settings - Fork 2
FEA-1986: Deprecate -p
/--path
#44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
…dart into index_all_files_by_default
todbachman-wf
approved these changes
Jun 12, 2023
QA +1
|
🚀 @Workiva/release-management-p 🚢 |
rmconsole-wf
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEA-1986
Currently only
./lib
files are indexedThis was done intentionally to allow consumers to opt-in to indexing
bin
andtest
directories depending on their needs, with the potential downside of reduced preformance.This PR abandons that desire, the majority of the tested code has already been indexed by the base file indexing, so the additional performance hits are just to index the files within
test
andbin
respectively (which in practice is not that much worse)This approach aligns a bit closer to
scip-typescript
where all files that are included intsconfig.json
are indexed. A later iteration can always support the ability to ignore a directory, if that is neededCloses #42