Skip to content

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Jul 19, 2023

ProjectRoot declared within the generated scip bindings was in the format of file://path/to/root, file:// is an invalid uri, and needs to be in the format of file:///

This pr utilizes Uri.file().toString to correctly generate the necessary uri

Fixes the issue with running scip stats as reported here: sourcegraph/scip#98

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk changed the title fixed projectRoot uri calculation Fixed projectRoot URI calculation Jul 19, 2023
@matthewnitschke-wk matthewnitschke-wk marked this pull request as ready for review July 19, 2023 13:46
@matthewnitschke-wk
Copy link
Contributor Author

QA +1

Verified running make run stats results in a successful call, meaning the projectRoot is set correctly

@matthewnitschke-wk
Copy link
Contributor Author

🚀 @Workiva/release-management-p 🚢

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants