avoid codeql log injection complaint #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperez-worklytics
approved these changes
Jul 4, 2024
jlorper
reviewed
Jul 5, 2024
java/impl/aws/src/main/java/co/worklytics/psoxy/aws/VaultAwsIamAuth.java
Outdated
Show resolved
Hide resolved
jlorper
approved these changes
Jul 5, 2024
…mAuth.java Co-authored-by: Jose Lorenzo <jose@worklytics.co>
eschultink
added a commit
that referenced
this pull request
Jul 11, 2024
* update release refs to rc-0.4.57 * avoid codeql log injection complaint (#746) * comment out log injection; explain it * Update java/impl/aws/src/main/java/co/worklytics/psoxy/aws/VaultAwsIamAuth.java Co-authored-by: Jose Lorenzo <jose@worklytics.co> --------- Co-authored-by: Jose Lorenzo <jose@worklytics.co> * document scopes per-connector for MSFT sources (#745) * document scopes, in one-pager per connector for MSFT * msft-teams * Update docs/sources/microsoft-365/msft-teams/README.md Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com> * Update docs/sources/microsoft-365/msft-teams/README.md Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com> * Update docs/sources/microsoft-365/msft-teams/README.md Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com> * Update docs/sources/microsoft-365/entra-id/README.md Co-authored-by: Jose Lorenzo <jose@worklytics.co> --------- Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com> Co-authored-by: Jose Lorenzo <jose@worklytics.co> * docs fixes (#747) * Fix AWS/GCP doc indexes * Format table using HTML Try to leverage GitBook's full width table feature * Create docs branch and display manual instructions on release * update gcp deps (#751) * update BOM * ARTIFACT_REGISTRY in bulk case (already done for API case) * update functions fw API * functions fw as provided * comment on functions FW via bom * update functions plugin * some cleanup * use top-level pom variable for gcp BOM version * fix bom unification * fix gcp build with latest maven (#750) * script to help check for the issue * pom that pins good version of maven-assembly-plugin (3.6.0) * more correct uber-jar assembly pom * revert assembly plugin version to latest, although leave pinned * add Implementation Guide to docs (#753) * implementation guide * Update docs/guides/implementation.md Co-authored-by: Jose Lorenzo <jose@worklytics.co> --------- Co-authored-by: Jose Lorenzo <jose@worklytics.co> * Support mailboxsettings for directory (#755) * Updated permission * Updated documentation * Updated changelog * fix MSFT owners data resource (#754) * Teams cleanup (#756) * Format * Drop not required permission * Using v1.0 in path * Move salesforce tests under rules directory * Drop from docs * Changelog update * Missing perm * java17 runtimes by default, in both AWS and GCP (#757) * GCP container scanning tooling (#758) * GCP container scanning tooling * Update docs/development/releases.md * prep release v0.4.57 (#752) * update release refs to v0.4.57 * improve CHANGELOG * port correct building to AWS case; improve check tool * tooling fixes (#760) * improve rc-to-main next steps, for clarity * fix prompt * expose param to set permissions boundary on roles (#761) --------- Co-authored-by: Jose Lorenzo <jose@worklytics.co> Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com> Co-authored-by: David <1151427+davidfq@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Change implications