Hotfix/1.2.2 #841
Merged
Hotfix/1.2.2 #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- data indexed depends on user indexing pref
- I don't completely understand why it wasn't being caught before - it seems to be now though
- previous implementation assumed content script was loaded at document start, running the main logic on `DOMContentLoaded` event - we recently changed the content script to load at document end, hence that event never gets triggered - now it waits on a promise which resolves when `document.readyState` is `complete`, which seems to work - should fix #840
# Conflicts: # src/activity-logger/background/tab-change-listeners.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #840. That was triggered by the recent change to when we load the content script: now at document end rather than start.
That's fine and easy to fix, but I can't remember why exactly we needed to change that though it's something to do with the twitter stuff. I looked at the commit history for it and found the commit that changed that (0a15e5b), although that also didn't have any details about the change.
It's not a big problem, but a good suggestion for future commits is to just put a brief sentence or two detailing the changes if they're not entirely obvious from the code. Try to think about if you looked at that commit weeks/months later, could you (and others) work out what the intention was from the code diff + commit message supplied?
The more self-documenting our commit log is, the less following up, or searching through notion/GH/slack threads we might need to do with people. No need to spend much time on them though.