Skip to content

Commit

Permalink
fix(settings): sound should start at 100% instead of 1%, closes #114
Browse files Browse the repository at this point in the history
  • Loading branch information
seiyria committed Feb 24, 2023
1 parent c522c79 commit 6a5bf0b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/app/services/visuals.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ export class VisualsService {
playSoundEffect(sound: string) {
const options = this.store.snapshot().options;

const masterPercent = (options[GameOption.SoundMaster] || 1) / 100;
const sfxPercent = (options[GameOption.SoundSFX] || 1) / 100;
const masterPercent = (options[GameOption.SoundMaster] || 100) / 100;
const sfxPercent = (options[GameOption.SoundSFX] || 100) / 100;

const soundByte = new Howl({
src: [`assets/sfx/${sound}.wav`],
Expand Down
4 changes: 2 additions & 2 deletions src/stores/options/options.functions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ export const defaultOptions: () => IOptions = () => ({
[GameOption.ColorTheme]: 'worldseller',
[GameOption.SidebarDisplay]: 'full',
[GameOption.TickTimer]: 1,
[GameOption.SoundMaster]: 0.5,
[GameOption.SoundSFX]: 1,
[GameOption.SoundMaster]: 50,
[GameOption.SoundSFX]: 100,
[GameOption.TelemetryErrors]: true,
[GameOption.TelemetrySavefiles]: true,
});
Expand Down

0 comments on commit 6a5bf0b

Please sign in to comment.