fix(loadout): loadout page should perform better with larger numbers …

…of items
WorldSellerGame · Mar 8, 2023 · ea2e229 · ea2e229
1 parent 8417840
commit ea2e229
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/app/pages/tradeskills/peripheral/combat/loadout/loadout.page.html b/src/app/pages/tradeskills/peripheral/combat/loadout/loadout.page.html
@@ -132,7 +132,7 @@
             <ion-card-content>
               <ion-list>
                 <ion-item *ngIf="learnedSkills.length === 0">You don't know any abilities!</ion-item>
-                <ion-item *ngFor="let skill of learnedSkills"
+                <ion-item *ngFor="let skill of learnedSkills; trackBy: trackBy"
                           class="cursor-pointer"
                           (click)="slotSkill(skill.name, selectedAbilityLoadoutIndex)"
                           [analyticsClick]="'Peripheral:Combat:Loadout:SlotAbility:' + skill.name">
@@ -150,7 +150,7 @@
             <ion-card-content>
               <ion-list>
                 <ion-item *ngIf="usableItems.length === 0">You don't have any usable items!</ion-item>
-                <ion-item *ngFor="let item of usableItems"
+                <ion-item *ngFor="let item of usableItems; trackBy: trackBy"
                           class="cursor-pointer"
                           (click)="slotItem(item, selectedItemLoadoutIndex)"
                           [analyticsClick]="'Peripheral:Combat:Loadout:SlotItem:' + item.name">
@@ -168,7 +168,7 @@
             <ion-card-content>
               <ion-list>
                 <ion-item *ngIf="usableFoods.length === 0">You don't have any usable food items!</ion-item>
-                <ion-item *ngFor="let item of usableFoods"
+                <ion-item *ngFor="let item of usableFoods; trackBy: trackBy"
                           class="cursor-pointer"
                           (click)="slotFood(item, selectedFoodLoadoutIndex)"
                           [analyticsClick]="'Peripheral:Combat:Loadout:SlotFood:' + item.name">

diff --git a/src/app/pages/tradeskills/peripheral/combat/loadout/loadout.page.ts b/src/app/pages/tradeskills/peripheral/combat/loadout/loadout.page.ts
@@ -89,6 +89,10 @@ export class LoadoutPage implements OnInit, OnDestroy {
     this.allUsableItems?.unsubscribe();
   }
 
+  trackBy(index: number) {
+    return index;
+  }
+
   getItemSkills(items: Record<string, IGameItem>): string[] {
     return getSkillsFromItems(items);
   }