Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace IRC with http service #98

Merged
merged 2 commits into from
Jun 1, 2016

Conversation

Chronial
Copy link
Collaborator

@Chronial Chronial commented Jun 1, 2016

This replaces the IRC server with a http service. The server code is here: https://github.com/Chronial/dscm-server

That server will also load nodes from IRC and publish nodes to IRC, so we can have a smooth transition.

The server will still just collect all nodes and send the list to all clients. But lack of IRC overhead and gzip compression already make this a lot more efficient

@Wulf2k It would be good if you could get this into a testing release as soon as possible.

@Wulf2k
Copy link
Owner

Wulf2k commented Jun 1, 2016

Awesome, but i don't have time to test it tonight. Do you feel confident
enough in the code for me to just merge it, compile it and upload it?
On May 31, 2016 19:13, "Chronial" notifications@github.com wrote:

This replaces the IRC server with a http service. Code for that is here:
https://github.com/Chronial/dscm-server

That server will also load nodes from IRC and publish nodes to IRC, so we
can have a smooth transition.

The server will still just collect all nodes and send the list to all
clients. But lack of IRC overhead and gzip compression already make this a
lot more efficient

@Wulf2k https://github.com/Wulf2k It would be good if you could get

this into a testing release as soon as possible.

You can view, comment on, or merge this pull request online at:

#98
Commit Summary

  • Replace IRC with http service

File Changes

Patch Links:


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#98, or mute the thread
https://github.com/notifications/unsubscribe/AOMBrpE2Q55btVHhWNkDJCeRSjxAUqb4ks5qHM6wgaJpZM4IrE1f
.

@Wulf2k
Copy link
Owner

Wulf2k commented Jun 1, 2016

And I just wasted more time by introducing conflicts into this one by merging the old one....

@Chronial
Copy link
Collaborator Author

Chronial commented Jun 1, 2016

I will have a look and resolve them.

@Wulf2k
Copy link
Owner

Wulf2k commented Jun 1, 2016

k, I was just about to release a separate compile of just PR #98 .

I'll hold off then, and sorry about screwing it up. I should really just "learn" Github one of these days.

@Chronial
Copy link
Collaborator Author

Chronial commented Jun 1, 2016

Alright, conflicts are resolved. I tested it again just in case, and everything looks fine.

@Wulf2k Wulf2k merged commit d1cb4b7 into Wulf2k:master Jun 1, 2016
This was referenced Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants