Skip to content

Fix Issue #83 - prevent a softlock in Tutorial #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2023
Merged

Fix Issue #83 - prevent a softlock in Tutorial #88

merged 1 commit into from
Feb 13, 2023

Conversation

Iridar
Copy link

@Iridar Iridar commented Jan 28, 2023

Fixes #83

MCM setting to Disable New Class Popup is ignored while in Tutorial to prevent a softlock.

@Iridar Iridar added this to the Version 1.1 milestone Jan 28, 2023
@Iridar Iridar added the bug Something isn't working label Jan 28, 2023
@Iridar Iridar self-assigned this Jan 28, 2023
robojumper
robojumper approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@robojumper robojumper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Some style linters would suggest collapsing this to a single if block but I don't mind it the way it's commented.

@Iridar
Copy link
Author

Iridar commented Feb 4, 2023

Seems reasonable to me. Some style linters would suggest collapsing this to a single if block but I don't mind it the way it's commented.

Yeah, initially I wanted to make it that way, but the code got exceedingly hard to read.

@Iridar Iridar added the ready-for-merge This has been reviewed and is ready to be merged label Feb 8, 2023
@Iridar Iridar merged commit ef9f94a into master Feb 13, 2023
@Iridar Iridar deleted the 83-tutorial-softlock branch February 13, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robojumper robojumper robojumper approved these changes

Assignees

@Iridar Iridar

Labels
bug Something isn't working ready-for-merge This has been reviewed and is ready to be merged
Projects
None yet
Milestone
Version 1.1
Development

Successfully merging this pull request may close these issues.

Game softlocks on promotion screen during Tutorial
3 participants
@Iridar @robojumper @ps2guides