Prevent Various Options from interfering with CPS #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robojumper
reviewed
Feb 3, 2023
| { | ||
| local UIScreenListener CDO; | ||
|
|
||
| CDO = UIScreenListener(class'XComEngine'.static.GetClassDefaultObject(class'VariousOptions.AdvancedAbilityButton')); |
There was a problem hiding this comment.
What happens at compile time with this import if the compiler doesn't see this class, and what happens at runtime if this package doesn't exist? I'd feel more comfortable if this avoided an import and instead used FindObject or something to find this CDO.
There was a problem hiding this comment.
Oh damn, you're right, this is supposed to be get CDO by name. Will adjust.
Iridar
force-pushed
the
85-various-options-killer
branch
from
dbb4517 to
c7a8a94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85
Prevent Various Options from interfering with CPS.