Skip to content

Conversation

Iridar
Copy link

@Iridar Iridar commented Jan 28, 2023

Fixes #72

Update localization to fix the incorrect error message for mutually exclusive abilities.

@Iridar Iridar added this to the Version 1.1 milestone Jan 28, 2023
@Iridar Iridar self-assigned this Jan 28, 2023
@Iridar Iridar added the bug Something isn't working label Jan 28, 2023
Copy link
Member

@robojumper robojumper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear improvement, though two different messages for the different cases would be clearer?

@Iridar
Copy link
Author

Iridar commented Feb 4, 2023

Clear improvement, though two different messages for the different cases would be clearer?

Yes, but unfortunately the check is done in CHL code: UnitState.MeetsAbilityPrerequisites(AbilityName);, and without duplicating said code - which I would prefer to avoid - CPS cannot tell whether the ability is missing another required ability, or a mutually exclusive ability is already unlocked.

@Iridar
Copy link
Author

Iridar commented Feb 5, 2023

Forgot to mention, there's a separate line above the ability description that will mention whether the ability requires another ability or is mutually exclusive with something, so it should still be pretty clear to the user in the end.

@Iridar Iridar added the ready-for-merge This has been reviewed and is ready to be merged label Feb 8, 2023
@Iridar Iridar merged commit 421e3cb into master Feb 13, 2023
@Iridar Iridar deleted the 72-mutually-exclusive-fix branch February 13, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready-for-merge This has been reviewed and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect localization for mutually exclusive abilities
3 participants