Replace Show Unreached Perks MCM toggle with a dropdown #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robojumper
reviewed
Feb 3, 2023
Ah yeah that's the MrNice's version I've been using. It's a huge timesaver, and includes a static macro for grabbing MCM settings values. Very QoL. |
Iridar
force-pushed
the
69-hide-only-training-center-perks-MCM
branch
from
3b5649f to
4ab60a2
Compare
|
There was an accidental edit to an unrelated line in one of the files, I removed it. |
Iridar
force-pushed
the
69-hide-only-training-center-perks-MCM
branch
from
4ab60a2 to
d43daec
Compare
|
Updated the code slightly so that two different places in code have a consistent view on what is a training center perk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69
Giggity
Previously, there was an MCM setting where the CPS would either hide all perks from unreached ranks or displayed all of them.
This PR replaces the toggle setting with a dropdown list, where the third option can be selected, which hides only perks that require Training Center from unreached ranks.