Skip to content

Test branch 2 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Test branch 2 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eaf775c
foo #4
snuyanzin Oct 21, 2022
0787c5c
foo #5
RyanSkraba Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,7 @@ CompletableFuture<CompletedCheckpoint> triggerCheckpoint(
@Nullable String externalSavepointLocation,
boolean isPeriodic) {

// aaaand an even better comment
CheckpointTriggerRequest request =
new CheckpointTriggerRequest(props, externalSavepointLocation, isPeriodic);
chooseRequestToExecute(request).ifPresent(this::startTriggeringCheckpoint);
Expand Down
1 change: 1 addition & 0 deletions ...client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,7 @@ private List<String> retrieveChangelogResult(
}

private void verifySinkResult(String path) throws IOException {
// new comment
final List<String> actualResults = new ArrayList<>();
TestBaseUtils.readAllResultLines(actualResults, path);
final List<String> expectedResults = new ArrayList<>();
Expand Down