Skip to content

Conversation

stan-janssen
Copy link
Contributor

@stan-janssen stan-janssen commented Sep 10, 2020

This commit adds support for adding your own Signature Properties when you are using the detached method. This use case is relevant in, for example, the OpenADR specification, which requires a ReplayProtect element to be included in the signature.

I added a parameter signature_properties to the XMLSigner.sign method, and a helper method that builds the required SignatureProperties structure and adds it to the result.

I also added a test case for this feature.

This addresses a real-life use case in a (hopefully) non-intrusive manner.

This commit adds support for adding your own Signature Properties when you are using the detached method. This use case is relevant in, for example, the OpenADR specification, which requires a ReplayProtect element to be included in the signature.
@kislyuk kislyuk merged commit 16060ef into XML-Security:master Sep 10, 2020
@kislyuk
Copy link
Member

kislyuk commented Sep 10, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants