Add support for adding Signature Properties to a detached signature #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for adding your own Signature Properties when you are using the detached method. This use case is relevant in, for example, the OpenADR specification, which requires a ReplayProtect element to be included in the signature.
I added a parameter
signature_properties
to theXMLSigner.sign
method, and a helper method that builds the required SignatureProperties structure and adds it to the result.I also added a test case for this feature.
This addresses a real-life use case in a (hopefully) non-intrusive manner.