Add explicit dependency on asn1crypto to setup.py #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=======================================
Coverage 95.26% 95.26%
=======================================
Files 3 3
Lines 591 591
=======================================
Hits 563 563
Misses 28 28Continue to review full report at Codecov.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the code is directly using asn1crypto library in addition to the cryptography library, this PR adds an explicit dependency on asn1crypto in the setup.py. It uses the same version restriction inside https://github.com/pyca/cryptography/blob/1.8.1/setup.py#L38 .
Also, a new version release on PyPI would be appreciated once PRs are all sorted out.