Repository navigation
Using uplink splice to reduce CPU time #6848
JkLondon
started this conversation in
Performance
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hello there!
On one of the heavily loaded servers (amd64 btw) I did a pprof check that showed that around 11% of CPU time was spent on the uplink buf.Copy.
I investigated this and found that we can cut the time by using splice for the uplink directly but @Fangliding rejected my PR (in the PR you can see the proposed implementation), saying that the expected performance change would be small (also you mentioned that a Linux/arm64 build could be used on Android but I think we can deal with it). To support the discussion I've attached the profiling graph below.
So, to sum up, 2 questions:
All reactions