Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated function names from TW #472

Merged
merged 4 commits into from
Oct 21, 2020
Merged

Conversation

thisac
Copy link
Contributor

@thisac thisac commented Oct 19, 2020

Context:
The The Walrus quantum refactor introduced new function names for a few different functions and deprecated the old names (still supporting them for some time). Strawberry Fields uses some of these functions and should thus be updated to use their new names.

Description of the Change:

  • find_scaling_adjacency_matrix is renamed to adj_scaling
  • find_scaling_adjacency_matrix_torontonian is renamed to adj_scaling_torontonian

No other renamed functions were used directly by Strawberry Fields.

Benefits:
There's no deprecation warning when using these function in SF.

Possible Drawbacks:
None

Related GitHub Issues:
None

@thisac thisac changed the title Update deprecated name from TW Update deprecated function names from TW Oct 19, 2020
@thisac thisac self-assigned this Oct 19, 2020
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thisac. Let's release the new Walrus version, and ensure this PR passes before merging it in

Copy link
Collaborator

@nquesada nquesada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating @thisac !

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #472 into master will decrease coverage by 0.97%.
The diff coverage is 99.41%.

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   97.84%   96.86%   -0.98%     
==========================================
  Files          58       70      +12     
  Lines        6784     7154     +370     
==========================================
+ Hits         6638     6930     +292     
- Misses        146      224      +78     
Impacted Files Coverage Δ
strawberryfields/apps/clique.py 100.00% <ø> (ø)
strawberryfields/apps/plot.py 100.00% <ø> (ø)
strawberryfields/apps/train/embed.py 100.00% <ø> (ø)
...awberryfields/backends/gaussianbackend/__init__.py 100.00% <ø> (ø)
strawberryfields/backends/gaussianbackend/ops.py 100.00% <ø> (+2.70%) ⬆️
strawberryfields/backends/shared_ops.py 96.11% <ø> (-0.98%) ⬇️
strawberryfields/compilers/__init__.py 100.00% <ø> (ø)
strawberryfields/compilers/compiler.py 100.00% <ø> (ø)
strawberryfields/compilers/fock.py 100.00% <ø> (ø)
strawberryfields/compilers/gaussian.py 100.00% <ø> (ø)
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96fca95...22e10f1. Read the comment docs.

@josh146 josh146 merged commit 414f035 into master Oct 21, 2020
@josh146 josh146 deleted the new-function-names branch October 21, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants