-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deprecated function names from TW #472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thisac. Let's release the new Walrus version, and ensure this PR passes before merging it in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating @thisac !
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
- Coverage 97.84% 96.86% -0.98%
==========================================
Files 58 70 +12
Lines 6784 7154 +370
==========================================
+ Hits 6638 6930 +292
- Misses 146 224 +78
Continue to review full report at Codecov.
|
Context:
The The Walrus quantum refactor introduced new function names for a few different functions and deprecated the old names (still supporting them for some time). Strawberry Fields uses some of these functions and should thus be updated to use their new names.
Description of the Change:
find_scaling_adjacency_matrix
is renamed toadj_scaling
find_scaling_adjacency_matrix_torontonian
is renamed toadj_scaling_torontonian
No other renamed functions were used directly by Strawberry Fields.
Benefits:
There's no deprecation warning when using these function in SF.
Possible Drawbacks:
None
Related GitHub Issues:
None