factorial for large numbers #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
factorials of numbers larger than 170 do not fit into a int, hence return float using the qarg `exact=True` when needed
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 77 77
Lines 8987 8989 +2
=======================================
+ Hits 8857 8859 +2
Misses 130 130
Continue to review full report at Codecov.
|
josh146
reviewed
Sep 23, 2021
josh146
approved these changes
Sep 23, 2021
There was a problem hiding this comment.
Nice catch @sduquemesa! Don't forget to add this to the changelog before merging it in 🙂
remove unneeded `else` statement Co-authored-by: Josh Izaac <josh146@gmail.com>
thisac
reviewed
Sep 23, 2021
test case for large numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Factorials of numbers larger than 170 do not fit into an
int, hence return float when neededDescription of the Change: use the
qarg exact=True/Falseonscipy.special.factorialwhen the result cannot be fitted inside anintBenefits: Error won't be raised when
factorialis called with a large numberPossible Drawbacks: None
Related GitHub Issues: #284