Skip to content

Conversation

nissessenap
Copy link
Contributor

Explains how to use the github actions workflow created for terraform.

@nissessenap
Copy link
Contributor Author

XenitAB/azure-devops-templates#89 still isn't merged, when it is we will tag it and then we will need to update these docs to match the correct tag to use.

@nissessenap nissessenap requested a review from bittrance October 20, 2021 13:34
Copy link
Contributor

@bittrance bittrance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this page be specifically about GitHub plus Azure or will it eventually grow to talk about GitHub plus AWS as well? If the former, the page title (and filename) should say so. If the latter, the headings should say this is about GitHub plus Azure (pushing the Terraform header down one level).

[basic pipeline](https://github.com/XenitAB/azure-devops-templates/terraform-docker-github/README.md)
for easy use.

Bellow you can find a example pipeline that uses the github action workflow.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bellow -> Below.

I think we usually name the "Terraform repo" fleet-infra? This text should prolly use that name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm 90% sure that fleet-infra is where we store flux gitops data to maintain flux itself and not terraform.
I can't find any example about fleet-infra except when it comes to flux. Do you have a example?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point is more that the text should say what repo you want to put the pipeline int.

Edvin Norling added 2 commits October 21, 2021 10:26
* Prepare for future AWS support in the way we are writing the doc
Copy link
Contributor

@bittrance bittrance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments below. I think this is easy to follow.

@nissessenap nissessenap merged commit a17eac0 into main Oct 21, 2021
@nissessenap nissessenap deleted the github branch October 21, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants