-
Notifications
You must be signed in to change notification settings - Fork 1
How to setup terraform CI in github #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
XenitAB/azure-devops-templates#89 still isn't merged, when it is we will tag it and then we will need to update these docs to match the correct tag to use. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this page be specifically about GitHub plus Azure or will it eventually grow to talk about GitHub plus AWS as well? If the former, the page title (and filename) should say so. If the latter, the headings should say this is about GitHub plus Azure (pushing the Terraform header down one level).
docs/xks/operator-guide/github.md
Outdated
[basic pipeline](https://github.com/XenitAB/azure-devops-templates/terraform-docker-github/README.md) | ||
for easy use. | ||
|
||
Bellow you can find a example pipeline that uses the github action workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bellow -> Below.
I think we usually name the "Terraform repo" fleet-infra? This text should prolly use that name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 90% sure that fleet-infra is where we store flux gitops data to maintain flux itself and not terraform.
I can't find any example about fleet-infra except when it comes to flux. Do you have a example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point is more that the text should say what repo you want to put the pipeline int.
* Prepare for future AWS support in the way we are writing the doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments below. I think this is easy to follow.
Explains how to use the github actions workflow created for terraform.