Style/standard #163
Merged
Style/standard #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds `npm run unit` as a discrete method to run just the tests
These changes are primarily:
> standard --fix
I also cleaned up some of the safe decisions like `one-var` and
`operator-linebreak`. There are still standard errors in this commit:
> npm run lint | wc -l
standard: Use JavaScript Standard Style (http://standardjs.com)
24
2 instances ignored, need to fix:
./lib/commands/servo.js:56:67: Expected error to be handled. (handle-callback-err)
./lib/commands/servo.js:87:14: Expected error to be handled. (handle-callback-err)
These changes are primarily:
> standard --fix lib/controllers/project.js
This file was skipped earlier because of issue with `await`. I disabled one line since fixing it requires more than linting:
./lib/controllers/project.js:311:74: Expected error to be handled. (handle-callback-err)
disabled regex creation warning, rather than fixing it, since this code will probably be refactored heavily in coming commits
Closed
theworkflow
approved these changes
Feb 7, 2017
theworkflow
requested changes
Feb 7, 2017
There was a problem hiding this comment.
Error when running npm test
Error: Cannot find module 'express'
at Function.Module._resolveFilename (module.js:469:15)
at Function.Module._load (module.js:417:25)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at Object.<anonymous> (/Users/Jeremiah/Code/xervo/cli/test/mockServer.js:1:77)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.require (module.js:497:17)
at require (internal/module.js:20:19)
at /Users/Jeremiah/Code/xervo/cli/node_modules/lab/lib/cli.js:104:23
at Array.forEach (native)
at Object.internals.traverse (/Users/Jeremiah/Code/xervo/cli/node_modules/lab/lib/cli.js:100:19)
at Object.exports.run (/Users/Jeremiah/Code/xervo/cli/node_modules/lab/lib/cli.js:49:29)
at Object.<anonymous> (/Users/Jeremiah/Code/xervo/cli/node_modules/lab/bin/lab:3:23)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.runMain (module.js:604:10)
at run (bootstrap_node.js:394:7)
at startup (bootstrap_node.js:149:9)
at bootstrap_node.js:509:3
|
|
|
Everything worked for me 👍 |
bsatrom
approved these changes
Feb 7, 2017
theworkflow
approved these changes
Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to make this easy to follow along commit by commit, since it will require a lot of review if you tried just looking at the changes..