Feature/lint files #89
Conversation
| modulus.io.print('Add-Ons provisioned for ' + projectName.verbose); | ||
| // ---------------------------------------------------------------------------- | ||
| addOn.printList = function (projectName, addons) { | ||
| var addonConfig,configItem, i; |
There was a problem hiding this comment.
You need a space between the first two items. And can you put i first? At first I didn't see it...would be more obvious at the front.
tzmanics
force-pushed
the
feature/lint-files
branch
from
c580946
to
fa8b0b8
Compare
| } | ||
| ], function(err, results) { | ||
| modulus.io.success('Feedback sent. Thank you for the message.'); | ||
| ], function (results) { // ignores 'error' |
There was a problem hiding this comment.
err is still the first param, even if you ignore it. You probably meant to remove all params since it does not appear to use any of them
tzmanics
force-pushed
the
feature/lint-files
branch
3 times, most recently
from
150223e
to
c8dc663
Compare
|
updated |
|
@tzmanics I think this branch looks good, ready to review sub-branches as you complete them |
Only use `Logger.debug` for CLI.
tzmanics
force-pushed
the
feature/lint-files
branch
from
7595c4c
to
46f5e0f
Compare
|
@tzmanics I'm afraid all this work might be a lost cause 😢 :
How do you feel about closing it and I will give it another shot |
|
created #163 which converts the project to |
Linted
lib/commandsdirectory files.