-
Notifications
You must be signed in to change notification settings - Fork 58
feat(split): child replica learn parent prepare list and checkpoint #309
Conversation
} | ||
|
||
// generate a checkpoint synchronously | ||
err = _app->sync_checkpoint(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里 sync_checkpoint 是什么原因?必须要 checkpoint 吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里child已经异步learn完成,包括checkpoint, prepare_list, private_log和in-memory mutation,这时打一个checkpoint相当于标识异步learn完成,而且方便接下来的catch up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
”方便接下来的catch up“ 我没有理解主要是哪些方面方便了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在异步learn完成之后,child还需要catch up在它进行异步learn过程中parent的states,这时打一个checkpoint,能把之前异步learn的states durable,更新一下last_durable_decree,主要是这个作用
Simple partition split process
More partition split discussion in issue #69
This pr solves the part of fifth step of partition split, which is bold in process description.
What this pr solved
is_prepare_list_copied
async_learn_tesk
is_cleaned
functionTests
child_copy_prepare_list
andchild_learn_states