This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
feat(dup): implement ship_mutation stage and mutation_batch #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
previously approved these changes
Sep 17, 2019
hycdong
reviewed
Sep 18, 2019
我对mutation_batch的功能还是有些疑问,mutation什么时候被加到热备的这个prepare_list里面的呢?是从private_log中load嘛?为什么还要对这个prepare_list进行prepare和commit呢?这个 |
是的,在 plog load 的时候用。 prepare/commit 是因为热备份需要保证最终一致性,所以发送方需要保证按照日志的顺序发,
|
hycdong
approved these changes
Sep 18, 2019
qinzuoyan
approved these changes
Sep 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the previous PR: #304.
ship_mutation
ship_mutation is a part of the duplication procedure:
It tries to ship mutations to remote via
mutation_duplicator
.mutation_batch
mutation_batch
is internally aprepare_list
to ensure the sequential orderof loaded mutations.