This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat: add table level latency perf counters #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2019 11:11
levy5307
changed the title
acelyc111
reviewed
Nov 4, 2019
added 2 commits
November 5, 2019 10:53
acelyc111
previously approved these changes
Nov 6, 2019
hycdong
previously approved these changes
Nov 6, 2019
neverchanje
reviewed
Nov 7, 2019
neverchanje
reviewed
Nov 7, 2019
acelyc111
previously approved these changes
Nov 14, 2019
neverchanje
reviewed
Nov 14, 2019
neverchanje
approved these changes
Nov 14, 2019
acelyc111
approved these changes
Nov 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add table level latency perf-counters for all of the table read or write operations.
1.Count all the storage request rpc codes into
std::vector<dsn::task_code> storage_rpc_req_codesfrom function register_storage_task_code, which would be called by creating storage rpc code.2.when a replica is created, using the replica's table name, a list of perf counters will be created for each task code in storage_rpc_req_codes. If a perf counter was already created, it would not created repeatly.
3.For read operations, the running time of
_app->on_request(request)is Statisticed in function replica::on_client_read.4.For write operations, a variable was added in mutation_update, which name is start_time_ns. So in execute_mutation function, the running time of the write operaiton will be statisticed by
dsn_now_ns() - update.start_time_ns.Related issue: apache/incubator-pegasus#406