This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix: fix meta response state to client during configuration query #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
approved these changes
Dec 12, 2019
levy5307
reviewed
Dec 12, 2019
| @@ -288,6 +288,30 @@ void meta_service_test_app::state_sync_test() | |||
| req.app_name = "make_no_sense"; | |||
| ss2->query_configuration_by_index(req, resp); | |||
| ASSERT_EQ(dsn::ERR_OBJECT_NOT_FOUND, resp.err); | |||
|
|
|||
| // 3.3 app is dropping/creating/recalling | |||
| std::shared_ptr<app_state> app = ss2->get_app(15); | |||
There was a problem hiding this comment.
我感觉这里用了好多15数字常量不太好，能不能统一到一个变量里？要不然把15改的话需要改一大片
neverchanje
approved these changes
Dec 12, 2019
neverchanje
changed the title
acelyc111
pushed a commit
that referenced
this pull request
Dec 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#332 resolve the core dump when assert the meta state, but the response state to client is not reasonable. This pr fix the bug.