Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The issues #268, #271, #324 and XinFinOrg/Local_DPoS_Setup#16 reported below problems about sync:
--gcmode archive
in command.checkSignersOnCheckpoint
returns below error during sync:invalid penalty list on checkpoint block
Masternodes lists are different in checkpoint header and snapshot
This PR fix the first problem. The second problem is caused by golang with v1.19 or above versions. The golang v1.14.15 is suggested to build this repo.
Types of changes
What types of changes does your code introduce to XDC network?
Impacted Components
Which part of the codebase this PR will touch base on,
Checklist
Test
I made some tests.
1.1 xinfin network
1.1.1 sync from genesis
sync script: https://github.com/gzliudan/Local_DPoS_Setup/blob/sync/xinfin-from-genesis.sh
result: catch up the latest block without any problem.
1.1.2 sync from snapshot
sync script: https://github.com/gzliudan/Local_DPoS_Setup/blob/sync/xinfin-from-snapshot.sh
result: catch up the latest block without any problem.
1.2 apothem network
1.2.1 sync from genesis
sync script: https://github.com/gzliudan/Local_DPoS_Setup/blob/sync/apothem-from-genesis.sh
result:
invalid gas used
when I use master branch. This error is solved by [the commitapothem network upgrade block
](ffa2bb5 on apothem branch).1.2.2 sync from snapshot
sync script: https://github.com/gzliudan/Local_DPoS_Setup/blob/sync/apothem-from-snapshot.sh
result: catch up the latest block without any problem.