Skip to content

Conversation

foxpy
Copy link
Contributor

@foxpy foxpy commented Mar 3, 2022

Previously, we have only been pointing to i7-11850H results, leaving everything else behind the scenes.

Now, when user clicks on link to results — user sees all benchmark results at once.

Previously, we have only been pointing to i7-11850H results,
leaving everything else behind the scenes.

Now, when user clicks on link to results — user sees all
benchmark results at once.
@foxpy foxpy requested a review from MBkkt as a code owner March 3, 2022 09:12
@MBkkt
Copy link
Member

MBkkt commented Mar 3, 2022

I think we want a list of benchmarks here, can you add other processors, or I will make it

@foxpy
Copy link
Contributor Author

foxpy commented Mar 3, 2022

I think we want a list of benchmarks here, can you add other processors, or I will make it

If we want to maintain links to all processors, we probbaly want them to be added automatically to README. Otherwise, we will have to manually add links after every benchmark result contribution there is. Sounds unpleasant.

@foxpy foxpy closed this Mar 3, 2022
@foxpy foxpy deleted the readme-benchmark-results branch March 3, 2022 11:26
@foxpy foxpy restored the readme-benchmark-results branch March 3, 2022 11:26
@foxpy
Copy link
Contributor Author

foxpy commented Mar 3, 2022

…I have deleted a wrong branch from command line.

@foxpy foxpy reopened this Mar 3, 2022
@foxpy
Copy link
Contributor Author

foxpy commented Mar 3, 2022

@MBkkt anyway, I propose two solutions:

  • merge this pull request as is;
  • automatically update README after successful ./run.sh run.

What do you like the most?

@MBkkt
Copy link
Member

MBkkt commented Mar 3, 2022

@foxpy How can we correct automatically update readme?
We can make a separate readme in future/result hm

@foxpy
Copy link
Contributor Author

foxpy commented Mar 9, 2022

We can make a separate readme in future/result hm

I will do that

@foxpy foxpy marked this pull request as draft March 9, 2022 12:37
@MBkkt
Copy link
Member

MBkkt commented Mar 9, 2022

We also need to modify run.sh
something like

echo "- [$proc]($proc/)\n" >> future/result/README.md

@foxpy foxpy marked this pull request as ready for review March 9, 2022 13:07
@MBkkt MBkkt merged commit 85b8bd5 into YACLib:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants