This repository has been archived by the owner on Jul 15, 2019. It is now read-only.
[resolves #34] Allow param to be passed to emitChange events; Default to... #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
… to the store instance instead of the store class
|
⛵ |
|
This would be a BC break for people relying on the class being passed in the change listener. |
|
@ublubu Does this seem reasonable to you? You would be able to access the storeName from within your change handler by accessing |
|
looks good to me |
mridgway
added a commit
that referenced
this pull request
Nov 18, 2014
[resolves #34] Allow param to be passed to emitChange events; Default to...
|
@ublubu This is now live in version 0.2.8. We did not bump minor version, so your next build will pick up the default parameter change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... the store instance instead of the store class