Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rollback functionality for create orchestration, cleanup linter errors #37

Merged
merged 3 commits into from
Jul 17, 2020
Merged

Add rollback functionality for create orchestration, cleanup linter errors #37

merged 3 commits into from
Jul 17, 2020

Conversation

fishnix
Copy link
Contributor

@fishnix fishnix commented Jul 7, 2020

No description provided.

tenyo
tenyo reviewed Jul 13, 2020
View reviewed changes
Copy link
Contributor

@tenyo tenyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice rollback logic, I'd just double-check the err to make sure the shadowing doesn't break the rollback, I've had some weird issues with that, probably best not to shadow it in the orchestrator.
Also, how did you run the linter?

orchestration/orchestrator.go Show resolved Hide resolved
orchestration/orchestration.go Show resolved Hide resolved
api/handlers_services.go Show resolved Hide resolved
@tenyo
Copy link
Contributor

tenyo commented Jul 13, 2020

👍

@fishnix
Move secrets under prefix, update Task execution role (#38)
991679e 
* move secrets under prefix, update Task execution role
@fishnix fishnix merged commit 3916b06 into master Jul 17, 2020
@fishnix fishnix deleted the cf322-spin-1598 branch March 28, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenyo tenyo tenyo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fishnix @tenyo