Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move secrets under prefix, update Task execution role #38

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Move secrets under prefix, update Task execution role #38

merged 2 commits into from
Jul 17, 2020

Conversation

fishnix
Copy link
Contributor

@fishnix fishnix commented Jul 13, 2020

Create secrets in secretmanager with the path spinup/<org>/<cluster|spaceid>, change the default IAM perms in task execution role policy to reference the path. The next step will be adding a policy to the secret itself to limit it to just the service/tasks within the cluster.

@damnski
Copy link
Contributor

damnski commented Jul 14, 2020

👍

@fishnix fishnix merged commit 991679e into cf322-spin-1598 Jul 17, 2020
fishnix added a commit that referenced this pull request Jul 17, 2020
@fishnix
Add rollback functionality for create orchestration, cleanup linter e…
3916b06 
…rrors (#37)

* add rollback functionality for create orchestration, cleanup lint errors
* Move secrets under prefix, update Task execution role (#38)
* Factor out apierror to a common library
@fishnix fishnix deleted the cf322-spin-1737 branch March 28, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fishnix @damnski