-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: |re
matching is not done correctly, so use is_match
instead of find_iter
#1212
Conversation
is_match
instead of find_iter
|re
matching is not done correctly, so use is_match
instead of find_iter
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1212 +/- ##
==========================================
+ Coverage 83.60% 83.61% +0.01%
==========================================
Files 26 26
Lines 23818 23835 +17
==========================================
+ Hits 19912 19929 +17
Misses 3906 3906
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hitenkoku Thank you so much for review :) Sorry... There was a regression case, so I'll draft it once... |
The detection result diff of hayabusa-sample-evtx was as follows.
|
@hitenkoku @YamatoSecurity Therefore, the difference in the number of detections above does not seem to be a problem :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fukusuket Sorry it took some time. I took some benchmarks and this PR is slightly faster, uses about the same memory and detects more! So LGTM!
What Changed
|re
modifier rule does not detect logs correctly #1211Evidence
Enviroment
Test
I run the steps to reproduce #1211 and confirmed that 6 cases were detected as follows.
I would appreciate it if you could review when you have time🙏